Make sure Darwin hosts are always mac_os_x #1470
Conversation
mac_os_x_server isn't a thing anymore and no third party darwin based operating systems ever took off. Fix this detectio and speed things up a tiny bit by assuming darwin == mac_os_x just like we already do with the platform_family Signed-off-by: Tim Smith <tsmith@chef.io>
|
@chilcote does this look like a valid way to resolve #1469. Correct me if I'm wrong, but there isn't a supported MacOS X Server anymore so we shouldn't have to worry about that distinction. I think that's the only historical reason we had this other than some 2010-era hope that someone might come out with a Darwin mac clone OS. |
|
Yep, macOS Server is just an app now. This should work, thanks! (will this be back-ported to chef15?) The change you made to platform.rb is exactly what I did locally to test and that solved it. |
|
Yeah I'll kick this back to Ohai 15 and make sure we get a chef release going |
|
When this lands, pretty please make a new chef installer that supports 10.16. Maybe another chef 16.2 build? |
|
We need 10.16 builders in Mac Stadium first. That's not going to happen overnight, but our releng folks know it's a request. |
|
@tas50 honestly that shouldn't matter too much. Build one for 10.15 and we can use that for now :). We don't ship any of the "OS specific" versions of chef anyway. |
mac_os_x_server isn't a thing anymore and no third party darwin based
operating systems ever took off. Fix this detectio and speed things up
a tiny bit by assuming darwin == mac_os_x just like we already do with
the platform_family
Signed-off-by: Tim Smith tsmith@chef.io