Properly detect NVME/XVD devices in ZFS zpools #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add another match in the zpool status regex and then update the existing unit test to have some NVME devices in it. Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
changed the title
|
Fixes #1546 |
jaymzh
approved these changes
Oct 30, 2020
|
True. We should get that noted in a bigger issue of: this plugin needs a better way to determine devices in zpools |
|
Also in general you give the pool the whole disk w/o the partition, but we should still support partitions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another match in the zpool status regex and then update the existing unit test to have some NVME/XVD devices in it.
Signed-off-by: Tim Smith tsmith@chef.io