Gather WPAR state in the AIX virtualization plugin #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
changed the title
Signed-off-by: Tim Smith <tsmith@chef.io>
This is an important thing to know about the wpars Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
aix_virtualization
branch
from
d8ccf00
to
250f0f1
Compare
phiggins
reviewed
Nov 18, 2020
| if wpar_no.to_i > 0 | ||
| virtualization[:wpar_no] = wpar_no | ||
| else | ||
| # the below parses the output of lswpar in the long format | ||
| so = shell_out("lswpar -L").stdout.scan(/={65}.*?(?:EXPORTED\n\n)+/m) | ||
| wpars = Mash.new | ||
| so.each do |wpar| | ||
| wpar_name = wpar.lines[1].split[0] | ||
| wpar_heading = wpar.lines[1].split |
There was a problem hiding this comment.
You could potentially simplify this a bit by using .split(" - ").
There was a problem hiding this comment.
I'm a bit nervous about relying on particular space counts. I had it that way originally and then went back to this one.
phiggins
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty important bit of information on the wpar.