Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of remote targets for Ohai #1698

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

thheinen
Copy link
Contributor

@thheinen thheinen commented Oct 8, 2021

Description

  • Fix platform type :target to specify an os_version attribute.
    This allows including a related plugin inside a cookbook's ohai segment as opposed to installation in the system (Crash due to Chef trying to access a nil value)
  • Add platform type :api to enable REST APIs as opposed to agent-less OS (e.g. Switches)
  • Fix a return value of Object type as opposed to all other branches returning String for this
  • Fix missing ? on nonruby_target? check

Related Issue

Bug fixes, somewhat Hackathon related... ;-)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Thomas Heinen <theinen@tecracer.de>
@thheinen thheinen requested review from a team as code owners October 8, 2021 08:48
@tas50 tas50 merged commit efbeece into chef:main Oct 8, 2021
@tas50
Copy link
Contributor

tas50 commented Oct 8, 2021

Thanks @tecracer-theinen

@thheinen thheinen deleted the fix/remote-ohai branch October 11, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants