Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Azure Metadata to overcome stale dates which caused test failures #1747

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Updated Azure Metadata to overcome stale dates which caused test failures #1747

merged 2 commits into from
Jun 2, 2022

Conversation

johnmccrae
Copy link
Contributor

@johnmccrae johnmccrae commented Apr 20, 2022 •
edited
Loading

Signed-off-by: John McCrae john.mccrae@progress.com

Description

This PR solves 2 problems. The first is to correct the Azure Metadata used in Ohai. It was stale and that was leading to date validation failures in testing. Secondly, this whole thing was tested against Ruby 3.1 to ensure there were no issues and that Ohai was ready to go.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@johnmccrae
Testing Ruby 3.1 support
8a60e98 
Signed-off-by: John McCrae <john.mccrae@progress.com>
@johnmccrae
Updated Testing Ruby 3.1 support to get past metadata errors
d27e6f2 
Signed-off-by: John McCrae <john.mccrae@progress.com>
@johnmccrae johnmccrae requested review from a team as code owners April 20, 2022 16:09
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jaymzh
jaymzh requested changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what bumping azure versions has to do with Ruby 3.1?

@johnmccrae johnmccrae changed the title Testing Ruby 3.1 support Updated Azure Metadata to overcome stale dates which caused test failures Jun 1, 2022
@johnmccrae johnmccrae merged commit 568f67c into main Jun 2, 2022
@johnmccrae johnmccrae deleted the jfm/ohai_ruby3.1 branch June 2, 2022 16:17
jaymzh
jaymzh reviewed Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh requested changes

@neha-p6 neha-p6 neha-p6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnmccrae @jaymzh @neha-p6