Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[block_device] Record firmware revision of nvme block devices #1787

Merged
merged 1 commit into from Feb 28, 2023

Conversation

saravan2
Copy link
Contributor

Enhancing the plugin to record the firmware of nvme block devices

Description

The sysfs end point for firmware in nvme block device differs from HDD. Added firmware_rev to the plugin check list to collect this information on servers with nvme block devices.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@saravan2 saravan2 requested review from a team as code owners February 22, 2023 04:54
Enhancing the plugin to record the firmware of nvme block devices whose sysfs endpoint differs from HDD

Signed-off-by: Saravanan D <saravanand@fb.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dafyddcrosby
Copy link

dafyddcrosby commented Feb 22, 2023

Confirmed https://github.com/torvalds/linux/blob/master/drivers/nvme/host/core.c#L3554 and my laptop (Fedora 37, 6.1.11 kernel) for firmware_rev

@jaymzh
Copy link
Collaborator

jaymzh commented Feb 28, 2023

Huh I don't see to be part of chef-infra-owners anymore. I'll need to get that fixed

@GeorgeWestwater
Copy link

Merge approved @jaymzh; please merge until we can fix the branch protection

@jaymzh
Copy link
Collaborator

jaymzh commented Feb 28, 2023

Looks like the GHE migration yanked me out of the chef-infra-owners group, so the UI doesn't know I am allowed to approve. But I AM allowed to force the merge. So after talking to @GeorgeWestwater I'm forcing the merge, and they'll work on fixing groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants