Lcg/fix network listeners #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to require 'sigar' early so that it blows up during the definition rather than execution with a LoadError (is this a bug in ohai core? this feels like a hack). also drop hpux and aix specificity, not sure why that got added.
i don't think this platform makes any sense, suspect we need to remove it everywhere
back out the require 'sigar' hack
- setup a class heirarchy of exceptions so i can easily rethrow any internal ohai error - catch all the non-internal errors from running the plugin and just warn on those - convert the argumenterror raises to ohai invalidplugin errors
| class DependencyCycle < Exception; end | ||
| class DependencyNotFound < Exception; end | ||
| class AttributeSyntaxError < Exception; end | ||
| class Error < Exception; end |
There was a problem hiding this comment.
Maybe we should change this to inherit from StandardError? The difference being that just rescue won't catch Exception, you have to rescue Exception explicitly. I don't think any of these exceptions represent bad enough situations that we want to force downstream users into using rescue Exception.
|
@danielsdeleo yeah, agreed, fixed that |
|
LGTM, though travis found a test failure. |
|
@danielsdeleo annoying to track down, but fixed |
lamont-granquist
added a commit
that referenced
this pull request
Jan 8, 2014
Lcg/fix network listeners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.