Move windows drivers out of kernel #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of minimal-ohai in chef, we don't want to grab a bunch of garbage
|
Yeah, this should make Ohai twice as fast on Windows, right @jdmundrawala ? |
|
minimal ohai + this will be significantly faster. This patch alone shaves off a little over a second on my box. |
|
👍 The change looks good to me. Can you explain "This needs to go out with minimal-ohai so that it's not a breaking change" though? |
|
So if we were to ship minimal-ohai without this, then removing this from kernel could break people expecting that it be loaded even with minimal-ohai. |
|
Gotcha. |
jaym
added a commit
that referenced
this pull request
Apr 27, 2015
Move windows drivers out of kernel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of minimal-ohai in chef, we don't want to
grab a bunch of garbage
cc @danielsdeleo @btm @smurawski @thommay @adamedx
This needs to go out with minimal-ohai so that it's not a breaking change