Handle old kernels where we can't determine the init system #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New kernels will always have /proc/1/comm, but older kernels don't. Those systems are all init based (debian 6, ubuntu 10.04, centos 5.11). A good number of these systems are EoL, but some like CentOS 5.11 are going to be around for several more years. We should probably support detecting init on them properly.
| end | ||
|
|
||
| init_package package_name | ||
| init_package File.exists?("/proc/1/comm") ? File.open("/proc/1/comm").gets.chomp : 'init' |
There was a problem hiding this comment.
any reason you can't/shouldn't just set package_name to init up top and leave the rest of the code untouched? I think it's probably a fair chunk more readable.
There was a problem hiding this comment.
I'm not a huge fan of default values that you potentially change later on. Without a comment it's often hard to understand why the initial value is set to something like init. When you explicitly say if this file doesn't have content then use init it becomes a bit more clean to me that you chose init due to another value.
|
one nit, but essentially 👍 |
|
ping @chef/client-core for review |
|
👍 |
|
there should be similar code in the platform helpers in core chef as well... |
tas50
added a commit
that referenced
this pull request
Dec 14, 2015
Handle old kernels where we can't determine the init system
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New kernels will always have /proc/1/comm, but older kernels don't.
Those systems are all init based (debian 6, ubuntu 10.04, centos 5.11).
A good number of these systems are EoL, but some like CentOS 5.11 are
going to be around for several more years. We should probably support
detecting init on them properly.