Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gem conflicts in ruby environments that load rake 11 #774

Merged
merged 2 commits into from
Mar 15, 2016

Conversation

danielsdeleo
Copy link
Contributor

#1. Allow rake 11.x.

Something in our Rakefile is using a deprecated API, but it doesn't seem to be breaking anything:

bundle exec rake -T
[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
rake build               # Build ohai-8.12.0.gem into the pkg directory
rake changelog           # Generate a Change log from GitHub
rake clean               # Remove any temporary products
rake clobber             # Remove any generated files
rake install             # Build and install ohai-8.12.0.gem into system gems
rake install:local       # Build and install ohai-8.12.0.gem into system gems without network access
rake release[remote]     # Create tag v8.12.0 and build and push ohai-8.12.0.gem to Rubygems
rake spec                # Run RSpec code examples
rake style               # Run RuboCop
rake style:auto_correct  # Auto-correct RuboCop offenses

#2. Make rake a dev dependency.

Running git grep -i rake -- lib gives zero results, so we probably just overlooked making rake a dev dep in the past.

@adamedx
Copy link

adamedx commented Mar 15, 2016

👍

1 similar comment
@mwrock
Copy link
Member

mwrock commented Mar 15, 2016

👍

@danielsdeleo danielsdeleo merged commit b813c8f into master Mar 15, 2016
@danielsdeleo danielsdeleo deleted the rake-is-a-dev-dep branch March 15, 2016 00:18
@mwrock mwrock added the Bug label Mar 15, 2016
@mwrock mwrock changed the title Rake is a dev dep Fix gem conflicts in ruby environments that load rake 11 Mar 15, 2016
@grosser
Copy link

grosser commented Mar 15, 2016

❤️ release coming ? :)

@danielsdeleo
Copy link
Contributor Author

@grosser it's on rubygems.org now.

@thommay thommay added Type: Bug Does not work as expected. and removed Bug labels Jan 24, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants