Don't pull chef from master #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ohai is `bundle installed` without the development group, bundler doesn't install the development gems but it still includes them in the gemfile solution. When chef-client is on an unreleased version, this results in the unreleased version of chef-client ending up in the Gemfile.lock. Because chef-client has an exact equality pin on chef-config, which ohai also uses, this results in ohai's Gemfile.lock pinning ohai to the unreleased version of chef-config. When the ohai executable is created by appbundler, this results in a broken executable that tries to load a version of chef-config that doesn't exist.
|
👍 |
|
kind of more fuel for chef-boneyard/chef-rfc#193 |
|
👍 |
thommay
added
Expeditor: Skip Version Bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ohai is
bundle installedwithout the development group, bundlerdoesn't install the development gems but it still includes them in the
gemfile solution. When chef-client is on an unreleased version, this
results in the unreleased version of chef-client ending up in the
Gemfile.lock. Because chef-client has an exact equality pin on
chef-config, which ohai also uses, this results in ohai's Gemfile.lock
pinning ohai to the unreleased version of chef-config. When the ohai
executable is created by appbundler, this results in a broken executable
that tries to load a version of chef-config that doesn't exist.