Fix the scala plugin to properly return data #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several problems with the scala plugin: 1) scala -version is returned on stderr not stdout so we were never setting this and thus the plugin never ran 2) If sbt or scala weren't installed it threw exceptions 3) we were storing shell outs value in the output value for no real reason 4) if scala failed for some reason, but sbt succeeded we weren't setting the sbt values since were relied on scala[:version] being set 5) the specs incorrectly mocked scala output to stdout 6) the specs that checked to make sure values weren't set didn't actually run the plugin so they would always no find scala's key While I was here I moved the version key for sbt into it's own key. This would allow us to add other sbt values in the future if we found them. If we make version to top level value we lose that ability forever.
|
👍 |
|
Great catches! 👍 |
tas50
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several problems with the scala plugin:
scala -version is returned on stderr not stdout so we were never setting this and thus the plugin never ran
If sbt or scala weren't installed it threw exceptions
we were storing shell outs return in the output value for no real reason
if scala failed for some reason, but sbt succeeded we weren't setting the sbt values since were relied on scala[:version] being set
the specs incorrectly mocked scala output to stdout
the specs that checked to make sure values weren't set didn't actually run the plugin so they would always no find scala's key
While I was here I moved the version key for sbt into it's own key. This would allow us to add other sbt values in the future if we found them. If we make version to top level value we lose that ability forever.