Extend set_attribute plugin helper method to set sub-attributes. #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review @chef/client-core |
| @@ -152,8 +152,19 @@ def from_with_regex(cmd, *regex_list) | |||
| end | |||
| end | |||
|
|
|||
| def set_attribute(name, *values) | |||
| @data[name] = Array18(*values) | |||
| def set_attribute(name, value, *values) | |||
There was a problem hiding this comment.
can this just be set_attribute(*keys, value)?
Use: - set_attribute(:attr, value) assigns attribute 'attr' value. - set_attribute(:attr, :subattr, value) assigns attribute 'attr/subattr' value. Extends to subattributes of arbitrary depth. Raises a TypeError if some :subattr is not an Array, Hash, or Mash (e.g., a String value).
mcquin
force-pushed
the
OHAI-794/set-attribute
branch
from
7ed9ece
to
0131341
Compare
|
You might want to look at chef/chef#5029, I'm implementing functional getter/setter APIs, but the words I'm using is read/write/unlink, also with a slightly different implementation. |
|
That's a neat implementation @lamont-granquist . Are we okay with merging this as-is? I don't see the need for an implementation re-write now. Perhaps a future a mixlib-attribute library could prove useful for unifying attribute access between Chef and Ohai. ;) |
|
@mcquin @lamont-granquist Any update on this? |
tas50
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use:
Raises a TypeError if some :subattr is not an Array, Hash, or Mash (e.g., a String value).
@tas50