Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log level selection when running the ohai command #942

Merged
merged 1 commit into from
Jan 20, 2017

Conversation

thommay
Copy link
Contributor

@thommay thommay commented Jan 20, 2017

When we're running Ohai as a standalone application, we need to fire up
the logger with our desired location, but when we're run from inside
Chef, we're passed the client's loggers.

( https://github.com/chef/chef/blob/master/lib/chef/application/client.rb#L398 )

Fixes: #878

When we're running Ohai as a standalone application, we need to fire up
the logger with our desired location, but when we're run from inside
Chef, we're passed the client's loggers.

Signed-off-by: Thom May <thom@chef.io>
@thommay thommay requested a review from tas50 January 20, 2017 15:09
@tas50
Copy link
Contributor

tas50 commented Jan 20, 2017

Works great locally for me.

@tas50 tas50 merged commit 3327203 into master Jan 20, 2017
@tas50 tas50 changed the title Only explicitly initialize a logger when needed Fix command log levels being ignored by only explicitly initialize a logger when needed Jan 23, 2017
@tas50 tas50 added the Bug label Jan 23, 2017
@thommay thommay added Type: Bug Does not work as expected. and removed Bug labels Jan 24, 2017
@thommay thommay changed the title Fix command log levels being ignored by only explicitly initialize a logger when needed Fix log level selection when running the ohai command Jan 24, 2017
@tas50 tas50 deleted the tm/fix_app_logging branch January 24, 2017 18:31
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants