Fix reserve stack segmentation fault when building on RHEL5 or below

[robbkidd]

Currently only affects 2.1.7 and 2.2.3. This patch taken from the fix
in Ruby trunk and expected to be included in future point releases.

https://redmine.ruby-lang.org/issues/11602

[robbkidd]

smacks forehead

[scotthain]

Patch itself looks good, once you clean up the assignment :)

[curiositycasualty]

👍 pendng 👌 from Travis

[robbkidd]

It takes sooo long to re-run the test builds. 😢

[robbkidd]

Only patched 2.1.7 and 2.2.3 on CentOS 5. Did not apply patch on CentOS 6, 7 or Ubuntu.

[vagrant@default-centos-511]$ find /var/cache/omnibus/src/ruby-* -name thread_pthread.c
/var/cache/omnibus/src/ruby-2.1.6/thread_pthread.c
/var/cache/omnibus/src/ruby-2.1.7/thread_pthread.c
/var/cache/omnibus/src/ruby-2.2.2/thread_pthread.c
/var/cache/omnibus/src/ruby-2.2.3/thread_pthread.c
[vagrant@default-centos-511]$ grep "ensure alloca" /var/cache/omnibus/src/ruby-*/thread_pthread.c
/var/cache/omnibus/src/ruby-2.1.7/thread_pthread.c:     limit[0] = 0; /* ensure alloca is called */
/var/cache/omnibus/src/ruby-2.2.3/thread_pthread.c:     limit[0] = 0; /* ensure alloca is called */

[scotthain]

LGTM 👍
@chef/omnibus-maintainers

[yzl]

👍

[schisamo]

chef-sugar's DSL is fully exposed so you could do:

if rhel? && 

Additionally you could compare using a true constraint with:

if rhel? && Chef::Sugar::Version(ohai['platform_version']).satisfies?('> 6')

[robbkidd]

I'm getting a variety of NameErrors trying to use sugar within omnibus-supermarket which is pinned to a pretty old version of omnibus. I'm inclined to keep the longer, but working direct calls to ohai.

[lamont-granquist]

👍 although also 👍 on sethc's comment on better using sugar.

[lamont-granquist]

based on omnibus-supermarket needing a yak shave to get it up to current standards lets just merge this one to unblock the supermarket team, without worrying about the sugar syntax fixes...

[robbkidd]

[schisamo]

@robbkidd just

[robbkidd]

I'm still not used to merging my own PRs.