Allow ohai versions > 17 to be used

[balasankarc]

Description

The restricton < 17 was originally added by 2777c5b in #1013 because omnibus-toolchain was still shipping Ruby 2.6 at that time, and Ohai 17 required Ruby 17. However, starting with chef/omnibus-toolchain#153, omnibus-toolchain is on Ruby 2.7+, and hence this restriction can be removed.

Without this, omnibus can't be used with Chef > 17 because of conflicting Ohai requirements between two.

---

Maintainers

Please ensure that you check for:

• [] If this change impacts git cache validity, it bumps the git cache
  serial number
• [] If this change impacts compatibility with omnibus-software, the
  corresponding change is reviewed and there is a release plan
• [] If this change impacts compatibility with the omnibus cookbook, the
  corresponding change is reviewed and there is a release plan

[balasankarc]

CI runs tests on Ruby 2.6. If we are to keep that, we might need something like the following in the gemspec.

diff --git a/omnibus.gemspec b/omnibus.gemspec
index 18b7f62e..6980d952 100644
--- a/omnibus.gemspec
+++ b/omnibus.gemspec
@@ -25,7 +25,15 @@ Gem::Specification.new do |gem|
   gem.add_dependency "chef-cleanroom",   "~> 1.0"
   gem.add_dependency "ffi-yajl",         "~> 2.2"
   gem.add_dependency "mixlib-shellout",  ">= 2.0", "< 4.0"
-  gem.add_dependency "ohai",             ">= 15"
+
+  # Ohai 17 requires Ruby 2.7 or later. If we are on an older Ruby, we pin Ohai
+  # to be < 17
+  if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
+    gem.add_dependency "ohai",             ">= 15", "< 17"
+  else
+    gem.add_dependency "ohai",             ">= 15"
+  end
+
   gem.add_dependency "ruby-progressbar", "~> 1.7"
   gem.add_dependency "thor",             ">= 0.18", "< 2.0"
   gem.add_dependency "license_scout",    "~> 1.0"

[tas50]

You'll want to remove the Ruby 2.6 testing here https://github.com/chef/omnibus/blob/main/.expeditor/verify.pipeline.yml#L13

[tas50]

It's probably a call for @lamont-granquist and @marcparadise, but it may just be time to nuke Ruby 2.6 support entirely.

[mttkay]

It's probably a call for @lamont-granquist and @marcparadise, but it may just be time to nuke Ruby 2.6 support entirely.

👍 Keep in mind we are merely 6 months away from EOL for Ruby 2.6: https://www.ruby-lang.org/en/downloads/branches/

So this should likely happen before end of March 2022 anyway.

[balasankarc]

@lamont-granquist @marcparadise ping. Could you comment on whether we want Ruby 2.6 support retained or removed from CI?

[balasankarc]

@tas50 @lamont-granquist @marcparadise Gentle reminder. :)