Add some verification and defensive coding #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotthain
force-pushed
the
shain/harden_dmg_applescript
branch
2 times, most recently
from
77da88d
to
b40ccf1
Compare
yzl
approved these changes
Feb 3, 2017
scotthain
force-pushed
the
shain/harden_dmg_applescript
branch
from
b40ccf1
to
4d31725
Compare
schisamo
approved these changes
Feb 3, 2017
|
@schisamo it was tested with an ad_hoc on harmony: http://manhattan.ci.chef.co/job/harmony-build/97/ |
jaymalasinha
approved these changes
Feb 3, 2017
scotthain
force-pushed
the
shain/harden_dmg_applescript
branch
from
4d31725
to
9ac251e
Compare
…kes the dmg pretty Signed-off-by: Scott Hain <shain@chef.io>
scotthain
force-pushed
the
shain/harden_dmg_applescript
branch
from
9ac251e
to
6efaf0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add some resilience to the applescript that makes the dmg pretty
Signed-off-by: Scott Hain shain@chef.io
Description
Mac builds fail relatively frequently because a finder window is/isn't open and is/isn't in the correct place, or because the Volumes are mounted in weird ways. This makes these issue a little less likely to happen and a little easier to troubleshoot.
/cc @chef/omnibus-maintainers <- This ensures the Omnibus Maintainers team are notified to review this PR.
@chef/engineering-services
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan