Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The volume name can be 1+n words so we need to quote the grep in the … #754

Merged
merged 1 commit into from Feb 14, 2017
Merged

The volume name can be 1+n words so we need to quote the grep in the … #754

merged 1 commit into from Feb 14, 2017

Conversation

scotthain
Copy link
Contributor

…OSX packaging code

Signed-off-by: Scott Hain shain@chef.io

@chef/engineering-services

Description

Briefly describe the new feature or fix here

/cc @chef/omnibus-maintainers <- This ensures the Omnibus Maintainers team are notified to review this PR.

Maintainers

Please ensure that you check for:

  • [] If this change impacts git cache validity, it bumps the git cache
    serial number
  • [] If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • [] If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

rhass
rhass approved these changes Feb 14, 2017
View reviewed changes
Copy link
Contributor

@rhass rhass left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Once travis is happy.

@scotthain
The volume name can be 1+n words so we need to quote the grep in the …
1cda7ae 
…OSX packaging code

Signed-off-by: Scott Hain <shain@chef.io>
rhass
rhass suggested changes Feb 14, 2017
View reviewed changes
Copy link
Contributor

@rhass rhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now requires an * in the string to match.

@scotthain scotthain merged commit 67964d9 into master Feb 14, 2017
@scotthain scotthain deleted the shain/fix_pkg_quoting branch February 14, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzl yzl yzl approved these changes

@rhass rhass rhass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scotthain @yzl @rhass