use 7zip for FastUnzip MSI action to boost zip expansion performance #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mwrock <matt@mattwrock.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have discovered that using 7zip to expand the MSI zip payload is significantly faster that tne C# library we currently use. chef/fastmsi-custom-action#6 alters the behavior of the CustomActionFastMsi.CA.dll to shell out to 7zip.
Testing with the chef MSI, it brought the install time from 2 minutes and 28 seconds down to 38 seconds.
Signed-off-by: mwrock matt@mattwrock.com