Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double logging removal of non-mach-o libs #988

Merged
merged 1 commit into from Jan 19, 2022
Merged

Avoid double logging removal of non-mach-o libs #988

merged 1 commit into from Jan 19, 2022

Commits on Nov 10, 2021

  1. Avoid double logging removal of non-mach-o libs 

    is_macho? would call is_binary?, which resulted in double logging. Just
duplicate the 1 line of logic and avoid double logging in the builds.
This will nuke hundreds of lines of log output on macs. I also changed
up these methods to returns instead of carrying around a boolean. It
feels more "ruby-like" now. Maybe that's just my personal preference for
flow control though.

Signed-off-by: Tim Smith <tsmith@chef.io>
    @tas50
    tas50 committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    d8aef34 View commit details
    Browse the repository at this point in the history