update nokogiri to quiet gem audit finding #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CVE alert bundle-audit produces does not really apply to Supermarket because the package built by omnibus uses libxml libraries directly, not the libxml2 libraries bundled with the nokogiri gem. But this change will quiet the gem audit. Signed-off-by: Robb Kidd <rkidd@chef.io>
... instead of running rake tasks through rake tasks. This is an attempt to figure out why travis is erroring when running bundler inside rake. Signed-off-by: Robb Kidd <rkidd@chef.io>
robbkidd
force-pushed
the
robb/update-nokogiri
branch
from
5b53e18
to
92f934a
Compare
tas50
approved these changes
Jul 18, 2018
robbkidd
force-pushed
the
robb/update-nokogiri
branch
from
9115e71
to
68ef923
Compare
There were changes in the ci-common tooling that made the existing Travis steps break. https://github.com/chef/ci-studio-common#changes-in-100 Signed-off-by: Robb Kidd <rkidd@chef.io>
robbkidd
force-pushed
the
robb/update-nokogiri
branch
from
68ef923
to
af6b217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CVE alert bundle-audit produces does not really apply to Supermarket because the package built by omnibus uses libxml libraries directly, not the libxml2 libraries bundled with the nokogiri gem. But this change will quiet the gem audit.