Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby to 2.5.3 #1769

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Update Ruby to 2.5.3 #1769

merged 1 commit into from
Oct 24, 2018

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Oct 23, 2018

This resolves 2 CVEs and multiple bugs

Signed-off-by: Tim Smith tsmith@chef.io

Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Because we keep force-pushing over each other, I'll stop making this change and request it here instead.

Need to update src/supermarket/engines/fieri/.ruby-version, too. That's Fieri's new home.

@tas50
Copy link
Contributor Author

tas50 commented Oct 23, 2018

Travis seems to be stuck

@robbkidd
Copy link
Contributor

Cool. We broke it.

@robbkidd
Copy link
Contributor

Turns out, our Travis builds were blocked for an unrelated reason. Therefore, I will resume my rebasing and force-pushing! Gonna merge'n'squash these and push back up to trigger a new Travis run.

force pushing never causes problems

This resolves 2 CVEs and multiple bugs

Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Robb Kidd <rkidd@chef.io>
@tas50
Copy link
Contributor Author

tas50 commented Oct 24, 2018

@robbkidd This one passes in travis now

@robbkidd
Copy link
Contributor

Yup! After I had help undoing "fixing" it yesterday.

Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruby

@robbkidd robbkidd merged commit f1aafa3 into master Oct 24, 2018
@robbkidd robbkidd deleted the ruby branch October 24, 2018 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants