disambiguate columns used in query ordering #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries using the named ordering options and also joins with other
tables were failing with:
ActionView::Template::Error: PG::AmbiguousColumn:
ERROR: column reference "id" is ambiguous
LINE 1: SELECT DISTINCT cookbook_followers_count, id AS alias_0, "c…
^
Database query was traced to these ordering options in the Cookbook
scopes.
Added tests for the API route and query parameters that triggered these
errors. Added tablenames to the column references to pass the tests.
Signed-off-by: Robb Kidd <rkidd@chef.io>
robbkidd
force-pushed
the
robb/disambiguate-columns-in-query-order
branch
from
6c55d37
to
c8860ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Queries using the named ordering options and also joins with other tables were failing with:
Database query was traced to these ordering options in the Cookbook scopes.
Added tests for the API route and query parameters that triggered these errors. Added tablenames to the column references to pass the tests.
Related Issue
Fixes #1892
Types of changes
New feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to change)Chore (non-breaking change that does not add functionality or fix an issue)Checklist:
I have updated the documentation accordingly.