Fix exceptions thrown by displaying an error #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 5.1 deprecated using `env` in controllers in favor of using `request.env`. This change switches to that and removes some methods that are not currently used anywhere. The result of the `env` calls being in place is that the exception show page rendering would itself cause an exception. Thus, all errors become 500 errors which heightens the suspicion of upstream proxies and load balancers. The application logs also get filled with stacktraces for simple non-matched route errors which no body has time for. Signed-off-by: Robb Kidd <rkidd@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rails 5.1 deprecated using
envin controllers in favor of usingrequest.env. This change switches to that and removes some methods that are not currently used anywhere.The result of the
envcalls being in place is that the exception show page rendering would itself cause an exception. Thus, all errors become 500 errors which heightens the suspicion of upstream proxies and load balancers. The application logs also get filled with stacktraces for simple non-matched route errors which no body has time for.Related Issue
Somewhat related to #1891 and its increased 500 errors.
Types of changes
Checklist:
I have updated the documentation accordingly.I have added tests to cover my changes.