Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FIPS for the Ubuntu builds #2053

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Conversation

dheerajd-msys
Copy link
Contributor

Signed-off-by: dheerajd-msys dhsingh@progress.com

Description

This change enables FIPS onto Ubuntu builds

Issues Resolved

Fixes #1956

Check List

@tas50
Copy link
Contributor

tas50 commented Jul 15, 2021

We will need to get the build working first so we can test this with an adhoc

@dheerajd-msys
Copy link
Contributor Author

ok @tas50 Will check that then.

@dheerajd-msys dheerajd-msys force-pushed the dheeraj/enable_fips_for_ubuntu branch from 881f31a to ea2a181 Compare July 22, 2021 17:42
@dheerajd-msys
Copy link
Contributor Author

Build https://buildkite.com/chef/chef-supermarket-master-omnibus-release/builds/125#17bcbeee-0208-4eab-b436-56ba128020c0 fails for the error Supermarket::S3Config::IncompleteConfig: Got some, but not all, of the required S3 configs. Must provide ["S3_BUCKET", "S3_REGION"] to configure cookbook storage in an S3 bucket.

@dheerajd-msys
Copy link
Contributor Author

@dheerajd-msys dheerajd-msys force-pushed the dheeraj/enable_fips_for_ubuntu branch 8 times, most recently from 583cf9e to 1125d66 Compare July 27, 2021 10:37
@dheerajd-msys
Copy link
Contributor Author

Adhoc build https://buildkite.com/chef/chef-supermarket-master-omnibus-adhoc/builds/80#201c6fe5-f377-4d5f-baa7-c79b75fc9e17 resolves the error yarn executable is not detected for commit 1125d66 . Although it still fails while bundle exec rake assets:precompile

@dheerajd-msys dheerajd-msys force-pushed the dheeraj/enable_fips_for_ubuntu branch from 1125d66 to 77e7a83 Compare July 27, 2021 13:00
@tas50
Copy link
Contributor

tas50 commented Jul 28, 2021

the s3 stuff is fixed on master already if you rebase, but we should chat more about the creation of a verify pipeline and a bk script to get around the yarn issue. I'm curious why we can't just install yarn within the existing omnibus definitions.

@dheerajd-msys dheerajd-msys force-pushed the dheeraj/enable_fips_for_ubuntu branch from 77e7a83 to d873e22 Compare July 29, 2021 06:13
@dheerajd-msys
Copy link
Contributor Author

@tas50 Thanks for fixing yarn issue. I was only trying to fix this yarn issue but was not able to grab that we could do it in the way as you did so went ahead and wrote that bk script. Nevermind I am going to revert that for now.

@dheerajd-msys dheerajd-msys force-pushed the dheeraj/enable_fips_for_ubuntu branch from d873e22 to 95a819e Compare July 29, 2021 07:15
@dheerajd-msys
Copy link
Contributor Author

Adhoc build is successful but supermarket-ctl test are failing https://buildkite.com/chef/chef-supermarket-master-omnibus-adhoc/builds/95#_

@tas50
Copy link
Contributor

tas50 commented Jul 29, 2021

the ctl commands are failing on the nodejs stuff still. I'm looking at getting a working nodejs install.

@dheerajd-msys dheerajd-msys self-assigned this Aug 5, 2021
@tas50 tas50 force-pushed the dheeraj/enable_fips_for_ubuntu branch from 58dce10 to b8b6497 Compare August 11, 2021 16:18
Signed-off-by: dheerajd-msys <dhsingh@progress.com>
@tas50 tas50 force-pushed the dheeraj/enable_fips_for_ubuntu branch from b8b6497 to 6c5cbb3 Compare August 11, 2021 16:19
@tas50 tas50 merged commit b8e5029 into master Aug 11, 2021
@tas50 tas50 deleted the dheeraj/enable_fips_for_ubuntu branch August 11, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable FIPS for the Ubuntu builds
2 participants