Changes for sorting cookbooks with deprecated flag #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msys-sgarg
added
the
Status: Sustaining Backlog
| end | ||
|
|
||
| it 'orders by updated_at descending when given "recently_updated"' do | ||
| great.touch | ||
|
|
||
| puts "dep cook book updated at #{deprecated_cookbook.updated_at} #{deprecated_cookbook.deprecated}" | ||
| puts " cookbook updated_at #{cookbook.updated_at} #{cookbook.deprecated}" |
There was a problem hiding this comment.
@msys-sgarg You might consider removing these "puts" statements from here in tests.
Signed-off-by: smriti <sgarg@msystechnologies.com>
msys-sgarg
force-pushed
the
smriti/1838_show_deprecated_cookbook_at_the_end_of_list
branch
from
7ed53df
to
b4f02f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smriti sgarg@msystechnologies.com
Description
We are sorting cookbooks with deprecated boolean field. Which will make sure, cookbooks which are deprecated are always shown at the end of the list on view
Issues Resolved
#1838
Check List