Changed cookie serializer from :hybrid to :json as hybrid serializer has security issues; Fixed collaboration_controller dynamic resource path brakeman issue; #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r dynamic resource path brakeman issue Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
RajeshPaul38
changed the title
…has security issues Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
RajeshPaul38
changed the title
saghoshprogress
requested changes
Aug 12, 2021
| # has been upgraded to version:5 around 4 years back. | ||
| # Changing this now as the chances of preexisting cookies which are more than 4 years old is very less. | ||
| # In worst case the cookie will not be supported and the user will be asked to signin again. | ||
| # If that's an issue we will revert it back to :hybrid |
| redirect_to( | ||
| resource | ||
| send(resource_path_str, resource) |
There was a problem hiding this comment.
what is the need for extra variables resource_path_str
There was a problem hiding this comment.
just for the readibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one brakeman test in ignore list; fixed collaboration_controller dynamic resource path brakeman issue
Description
Issues Resolved
Check List