Changes for progress url being picked from wrong ENV variable #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msys-sgarg
force-pushed
the
smriti/2155_footer_links_pointing_to_wrong_url
branch
2 times, most recently
from
7b0ea88
to
573a4c0
Compare
tas50
reviewed
Aug 18, 2021
| @@ -23,7 +23,7 @@ def chef_www_url(extra = nil) | |||
| end | |||
|
|
|||
| def progress_www_url(extra = nil) | |||
| url = ENV["CHEF_WWW_URL"] || "https://www.#{progress_domain}" | |||
| url = ENV["PROGRESS_WWWW_URL"] || "https://www.#{progress_domain}" | |||
There was a problem hiding this comment.
Suggested change
| url = ENV["PROGRESS_WWWW_URL"] || "https://www.#{progress_domain}" | |
| url = ENV["PROGRESS_WWW_URL"] || "https://www.#{progress_domain}" |
Signed-off-by: smriti <sgarg@msystechnologies.com>
msys-sgarg
force-pushed
the
smriti/2155_footer_links_pointing_to_wrong_url
branch
from
573a4c0
to
5a842d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smriti sgarg@msystechnologies.com
Description
Supermarket production env is setting value for this env variable ENV[CHEF_WWW_URL] to
chef.io. Since this env variable is getting used at some other place in application too, I am introducing a new env variable - ENV[PROGRESS_WWW_URL] which will have a value aswww.progress.comand will resolve error we are getting in footer urlIssues Resolved
#2155
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List