Changes for supermarket banner for announcements #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msys-sgarg
force-pushed
the
smriti/2292_banner_about_maintenance_window
branch
from
df6ea2f
to
e6b75f6
Compare
Simplecov Report
|
Signed-off-by: smriti <sgarg@msystechnologies.com> div id documented for better understanding Signed-off-by: smriti <sgarg@msystechnologies.com>
msys-sgarg
force-pushed
the
smriti/2292_banner_about_maintenance_window
branch
from
048995d
to
5f2a10a
Compare
…g partial Signed-off-by: smriti <sgarg@msystechnologies.com>
Signed-off-by: smriti <sgarg@msystechnologies.com>
| @@ -20,7 +20,7 @@ | |||
| <% end %> | |||
| <%= csrf_meta_tags %> | |||
| <% unless air_gapped? %> | |||
| <%= render 'analytics' %> | |||
| <%= render partial: 'application/analytics' %> | |||
There was a problem hiding this comment.
Do we really need partial, i think it will work without partial
<%= render 'application/analytics' %>
There was a problem hiding this comment.
It can.. but adding partial makes it more readable in my opinion
Signed-off-by: smriti <sgarg@msystechnologies.com>
saghoshprogress
approved these changes
Oct 25, 2021
saghoshprogress
deleted the
smriti/2292_banner_about_maintenance_window
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smriti sgarg@msystechnologies.com
Description
We have added a new partial to render banner for supermarket announcements.
Also introduced once env variable which when defined will be rendered on supermarket main page. This will also help to update the banner text without requiring a code change in future.
Also introduced specs for application.html.erb
Issues Resolved
#2292
Check List