Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Font Awesome from 4 to 5.15.4 #2324

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

antima-gupta
Copy link
Contributor

Signed-off-by: antima-gupta agupta@msystechnologies.com

Description

  • Updated font-awesome 4 to 5
  • Added new fonts and font-awesome css.
  • Updated UI to display font-awesome icons.
  • Made css fixes.

Issues Resolved

#1506

Check List

@antima-gupta antima-gupta requested review from a team as code owners October 28, 2021 12:36
@antima-gupta antima-gupta self-assigned this Oct 28, 2021
@github-actions
Copy link

Simplecov Report

Covered Threshold
98.3% 90%

@tas50
Copy link
Contributor

tas50 commented Nov 4, 2021

@antima-gupta Have you had a chance to evaluate where in the UI this changed things?

@antima-gupta
Copy link
Contributor Author

antima-gupta commented Nov 5, 2021

@antima-gupta Have you had a chance to evaluate where in the UI this changed things?

@tas50 Yeah, this change is showing all the font awesome icons on the UI for example fa-bars, fa-github, fa-user
etc....

Added new fonts and font-awesome css.
Updated UI to display font-awesome icons.
Made css fixes.

Signed-off-by: antima-gupta <agupta@msystechnologies.com>
@antima-gupta antima-gupta force-pushed the antima/updated-font-awesome-version branch from d4c91a8 to ddd7342 Compare November 10, 2021 12:45
@antima-gupta
Copy link
Contributor Author

@tas50 tas50 merged commit 4ab4a67 into main Dec 29, 2021
@tas50 tas50 deleted the antima/updated-font-awesome-version branch December 29, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants