Updated the log directory permission #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for chef-supermarket ready! 🔨 Explore the source changes: 99698a5 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/61d5704ad6dac20008a23899 😎 Browse the preview: https://deploy-preview-2376--chef-supermarket.netlify.app |
Simplecov Report
|
tas50
reviewed
Nov 15, 2021
tas50
suggested changes
Nov 17, 2021
RajeshPaul38
approved these changes
Nov 23, 2021
|
We may also need to change other recipes https://github.com/chef/supermarket/blob/main/omnibus/cookbooks/omnibus-supermarket/recipes/redis.rb#L31 |
RajeshPaul38
approved these changes
Dec 13, 2021
|
There's already a PR for the same purpose. Have we included all the relevant changes out of the other PR? |
dheerajd-msys
force-pushed
the
sabya/update_log_permission
branch
from
fdf30a4
to
1a64e30
Compare
|
@chef/docs-team Please take a look 👀 |
kagarmoe
suggested changes
Jan 3, 2022
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: Dheeraj Singh Dubey <dhsingh@progress.com>
Signed-off-by: Dheeraj Singh Dubey <dhsingh@progress.com>
dheerajd-msys
force-pushed
the
sabya/update_log_permission
branch
from
1a64e30
to
99698a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: saghoshprogress saghosh@progress.com
Added option to modify the log directory permission, default will remain the same.
Issues Resolved
Issues
Check List
https://buildkite.com/chef/chef-supermarket-main-omnibus-adhoc/builds/264#1c7d3371-3a9e-4019-a442-831b6b23c7a2