Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed rails autoloader version from 5.1 to 6.0 #2380

Merged

Conversation

RajeshPaul38
Copy link
Contributor

@RajeshPaul38 RajeshPaul38 commented Nov 16, 2021

Signed-off-by: Rajesh Paul rajesh.paul@progress.com

Description

Changed rails autoloader version from 5.1 to 6.0

With the older version it was failing to autoload namesapced classes under app/model. Hence running reload! in rails console doesn't reload such classes. With this change the auto-reloading works perfectly. This doesn't add any feature but will help developers test their changes seamlessly without being needed to restart rails console every time for testing any changes.

Issues Resolved

#2378

Check List

Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38 RajeshPaul38 requested review from a team as code owners November 16, 2021 08:12
@netlify
Copy link

netlify bot commented Nov 16, 2021

👷 Deploy Preview for chef-supermarket processing.

🔨 Explore the source changes: 79bbcbe

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/619367ed2c398f0008425da5

@github-actions
Copy link

Simplecov Report

Covered Threshold
98.3% 90%

@RajeshPaul38 RajeshPaul38 linked an issue Nov 17, 2021 that may be closed by this pull request
@RajeshPaul38
Copy link
Contributor Author

Basic dev testing done for this change. Supermarket is working with chef-server oc-id.

@RajeshPaul38 RajeshPaul38 changed the title WIP: changed rails autoloader version from 5.1 to 6.0 Changed rails autoloader version from 5.1 to 6.0 Nov 17, 2021
@RajeshPaul38
Copy link
Contributor Author

@saghoshprogress saghoshprogress merged commit a282ffc into main Nov 17, 2021
@saghoshprogress saghoshprogress deleted the rajeshPaul38-upgrade-rails-autoloader-version-2378 branch November 17, 2021 16:43
@saghoshprogress saghoshprogress restored the rajeshPaul38-upgrade-rails-autoloader-version-2378 branch November 18, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade rails autoloader from version 5.1 to 6.0
2 participants