Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed gem: ruby-filemagic; replaced with built in ruby module: IO #2424

Merged
merged 9 commits into from
Dec 16, 2021
Merged

Removed gem: ruby-filemagic; replaced with built in ruby module: IO #2424

merged 9 commits into from
Dec 16, 2021

Conversation

RajeshPaul38
Copy link
Contributor

@RajeshPaul38 RajeshPaul38 commented Dec 4, 2021 •
edited

Description

Removed gem: ruby-filemagic
Replaced with built in ruby module: IO

Issues Resolved

#2320

Check List

@RajeshPaul38 RajeshPaul38 requested review from a team as code owners December 4, 2021 06:57
@netlify
Copy link

netlify bot commented Dec 4, 2021 •
edited

👷 Deploy Preview for chef-supermarket processing.

🔨 Explore the source changes: 103ec09

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/61b75dc3e0ab2000075ef6dc

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

Simplecov Report

Covered Threshold
97.24% 90%

@RajeshPaul38
Copy link
Contributor Author

RajeshPaul38 commented Dec 6, 2021 •
edited

Build: https://buildkite.com/chef/chef-supermarket-main-omnibus-adhoc/builds/300

@RajeshPaul38 RajeshPaul38 linked an issue Dec 6, 2021 that may be closed by this pull request
Investigate setting Permissions-Policy HTTP headers #2298
Closed
@RajeshPaul38
require util file path corrected
c126b6d
@RajeshPaul38
new util file relative path inclusion issue with fieri specs fixed
987564f 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38
chefstyle linter issue fixed
9b33f33 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38 RajeshPaul38 changed the title WIP: Removed gem: ruby-filemagic; replaced with built in ruby module: IO Removed gem: ruby-filemagic; replaced with built in ruby module: IO Dec 8, 2021
@RajeshPaul38
added testcase for Utils::FileFormat class
23dbe74 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38
fixed lint errors
14eb205 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
dheerajd-msys
dheerajd-msys approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@dheerajd-msys dheerajd-msys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!!

@RajeshPaul38 RajeshPaul38 changed the title Removed gem: ruby-filemagic; replaced with built in ruby module: IO WIP: Removed gem: ruby-filemagic; replaced with built in ruby module: IO Dec 10, 2021
@RajeshPaul38
Copy link
Contributor Author

Have tested cookbook upload functionality. Moving out of WIP

@RajeshPaul38
renamed spec/assets as spec/fixtures
103ec09 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38 RajeshPaul38 changed the title WIP: Removed gem: ruby-filemagic; replaced with built in ruby module: IO Removed gem: ruby-filemagic; replaced with built in ruby module: IO Dec 13, 2021
@saghoshprogress saghoshprogress merged commit 582c24f into main Dec 16, 2021
@saghoshprogress saghoshprogress deleted the rajeshpaul38/remove-filemagic/2320 branch December 16, 2021 07:22
@RajeshPaul38 RajeshPaul38 removed a link to an issue Dec 16, 2021
Investigate setting Permissions-Policy HTTP headers #2298
Closed
@RajeshPaul38 RajeshPaul38 linked an issue Dec 16, 2021 that may be closed by this pull request
Investigate if we can move off ruby-filemagic #2320
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheerajd-msys dheerajd-msys dheerajd-msys approved these changes

@saghoshprogress saghoshprogress saghoshprogress approved these changes

Assignees

@RajeshPaul38 RajeshPaul38

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate if we can move off ruby-filemagic
3 participants
@RajeshPaul38 @dheerajd-msys @saghoshprogress