Change chef downloads url #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manick Vel <mkumaravel@msystechnologies.com>
|
✔️ Deploy Preview for chef-supermarket ready! 🔨 Explore the source changes: 9f76e92 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/61cd9677653c790008f67f1f 😎 Browse the preview: https://deploy-preview-2449--chef-supermarket.netlify.app |
|
LGTM |
dheerajd-msys
approved these changes
Dec 20, 2021
tas50
suggested changes
Dec 29, 2021
| @@ -38,7 +38,7 @@ def chef_docs_url(extra = nil) | |||
| end | |||
|
|
|||
| def chef_downloads_url(extra = nil) | |||
| url = ENV["CHEF_DOWNLOADS_URL"] || "https://downloads.#{chef_domain}" | |||
| url = ENV["CHEF_DOWNLOADS_URL"] || "https://#{chef_domain}/downloads" | |||
There was a problem hiding this comment.
Is this going to be missing the www?
| @@ -74,7 +74,7 @@ | |||
|
|
|||
| describe "downloads url" do | |||
| let(:meth) { :chef_downloads_url } | |||
| let(:url) { "https://downloads.chef.io" } | |||
| let(:url) { "https://chef.io/downloads" } | |||
There was a problem hiding this comment.
Suggested change
| let(:url) { "https://chef.io/downloads" } | |
| let(:url) { "https://www.chef.io/downloads" } |
| @@ -38,7 +38,7 @@ def chef_docs_url(extra = nil) | |||
| end | |||
|
|
|||
| def chef_downloads_url(extra = nil) | |||
| url = ENV["CHEF_DOWNLOADS_URL"] || "https://downloads.#{chef_domain}" | |||
| url = ENV["CHEF_DOWNLOADS_URL"] || "https://#{chef_domain}/downloads" | |||
There was a problem hiding this comment.
Suggested change
| url = ENV["CHEF_DOWNLOADS_URL"] || "https://#{chef_domain}/downloads" | |
| url = ENV["CHEF_DOWNLOADS_URL"] || "https://www.#{chef_domain}/downloads" |
Signed-off-by: Manick Vel <mkumaravel@msystechnologies.com>
dheerajd-msys
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manick Vel mkumaravel@msystechnologies.com
Description
Change chef downloads url from downloads.chef.io to https://www.chef.io/downloads
Issues Resolved
#2350
Check List