Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruby-filemagic dep from fieri #2483

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Remove ruby-filemagic dep from fieri #2483

merged 1 commit into from
Jan 11, 2022

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jan 3, 2022

We removed the use of this and removed it from the main gemfile, but not from the fieri dep.

Signed-off-by: Tim Smith tsmith@chef.io

@tas50 tas50 requested review from a team as code owners January 3, 2022 04:52
@netlify
Copy link

netlify bot commented Jan 3, 2022

👷 Deploy Preview for chef-supermarket processing.

🔨 Explore the source changes: 0649b4c

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/61dc7065d7561c0009c2df3b

@github-actions github-actions bot added the Documentation Gets work onto the docs board label Jan 3, 2022
@tas50 tas50 removed the Documentation Gets work onto the docs board label Jan 3, 2022
@github-actions github-actions bot added the Documentation Gets work onto the docs board label Jan 3, 2022
@RajeshPaul38
Copy link
Contributor

Unit tests are failing @tas50

@tas50
Copy link
Contributor Author

tas50 commented Jan 5, 2022

@RajeshPaul38 green after a rebase

We removed the use of this and removed it from the main gemfile, but not from the fieri dep.

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 merged commit db32cba into main Jan 11, 2022
@tas50 tas50 deleted the ruby-filemagic branch January 11, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Gets work onto the docs board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants