Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Expeditor configs to check habitat build #2494

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

saghoshprogress
Copy link
Contributor

Description

Added expeditor configs to check the habitat build.
We need to test the build for habitat for this build #2453

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

@netlify
Copy link

netlify bot commented Jan 5, 2022

👷 Deploy Preview for chef-supermarket processing.

🔨 Explore the source changes: 42e6d07

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/620390d8ec76fe0008962a30

Copy link
Contributor

@jeremiahsnapp jeremiahsnapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@@ -42,9 +45,11 @@ changelog:
- "Type: Tech Debt": "Maintenance Updates"

pipelines:
- omnibus/release:
env:
- IGNORE_CACHE: true # caching causes constant build failures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you want to remove IGNORE_CACHE=true from the omnibus/release pipeline?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You really want this

Copy link
Contributor

@msys-sgarg msys-sgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new lines to the end of the files, also I dont think removing IGNORE_CACHE is a good idea from the pipeline configurations.

@dheerajd-msys
Copy link
Contributor

DCO sing-off is missing

@antima-gupta
Copy link
Contributor

@saghoshprogress DCO sing-off is missing.

Signed-off-by: smriti <sgarg@msystechnologies.com>
@msys-sgarg msys-sgarg force-pushed the saghosh/add-expeditor-for-habitat branch from 2643b81 to 42e6d07 Compare February 9, 2022 10:00
Copy link
Contributor

@msys-sgarg msys-sgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@saghoshprogress saghoshprogress merged commit 825ae2b into main Feb 10, 2022
@saghoshprogress saghoshprogress deleted the saghosh/add-expeditor-for-habitat branch February 10, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants