-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Expeditor configs to check habitat build #2494
Conversation
👷 Deploy Preview for chef-supermarket processing. 🔨 Explore the source changes: 42e6d07 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/620390d8ec76fe0008962a30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@@ -42,9 +45,11 @@ changelog: | |||
- "Type: Tech Debt": "Maintenance Updates" | |||
|
|||
pipelines: | |||
- omnibus/release: | |||
env: | |||
- IGNORE_CACHE: true # caching causes constant build failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure you want to remove IGNORE_CACHE=true from the omnibus/release pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really want this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add new lines to the end of the files, also I dont think removing IGNORE_CACHE is a good idea from the pipeline configurations.
DCO sing-off is missing |
@saghoshprogress DCO sing-off is missing. |
Signed-off-by: smriti <sgarg@msystechnologies.com>
2643b81
to
42e6d07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
Added expeditor configs to check the habitat build.
We need to test the build for habitat for this build #2453
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List