Pull in the latest cookstyle and allow dependabot to bump it #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy Preview for chef-supermarket processing. 🔨 Explore the source changes: 3682451 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/61fd6480b0ec8c0007a0a127 |
There's lots of cookstyle releases and we want to make sure we can always pull in new releases. Signed-off-by: Tim Smith <tsmith@chef.io>
|
DCO sign-off is missing @tas50 |
|
@dheerajd-msys DCO is there. The bot just isn't the best |
|
Adhoc build https://buildkite.com/chef/chef-supermarket-main-omnibus-adhoc/builds/351 is in progress. Can approve post it's success |
antima-gupta
reviewed
Feb 7, 2022
| @@ -82,7 +82,7 @@ group :test do | |||
| end | |||
|
|
|||
| group :development, :test do | |||
| gem "chefstyle", "2.1.3" | |||
| gem "chefstyle" | |||
There was a problem hiding this comment.
why are we using this cookstyle gem in common gems as well as inside group?
There was a problem hiding this comment.
This is chefstyle which is used for our ruby code vs. cookstyle which is used for cookbook code
dheerajd-msys
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are lots of cookstyle releases and we want to make sure we can always pull in new releases.
Signed-off-by: Tim Smith tsmith@chef.io