daemon: Enable to handle user defined control codes #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 to 255 for windows service's control codes are user-defined: https://docs.microsoft.com/en-us/windows/win32/api/winsvc/nf-winsvc-controlservice but win32-service doesn't handle these codes. This commit adds a handler for them. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
force-pushed
the
user-defined-control-code
branch
from
b4dc5a1
to
fe29ced
Compare
|
@tas50 Any thoughts? |
tas50
added
the
Expeditor: Bump Version Minor
|
Totally missed this. thanks @ashie |
|
Thanks! |
ashie
added a commit
to fluent/fluentd
that referenced
this pull request
Nov 10, 2021
We need chef/win32-service#74 to support additional commands of fluent-ctl Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
128 to 255 for windows service's control codes are user-defined code:
but win32-service doesn't handle these codes.
This commit adds a handler for them.
Issues Resolved
None.
Check List
win32-service/test/test_win32_daemon.rb
Lines 7 to 8 in bfeaedf