Fix to set user information at the time of task creation #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vasu1105 <vasundhara.jagdale@msystechnologies.com>
btm
reviewed
Jun 4, 2018
lib/win32/taskscheduler.rb
Outdated
| @@ -491,17 +491,24 @@ def priority=(priority) | |||
| # trigger variable is a hash of options that define when the scheduled | |||
| # job should run. | |||
| # | |||
| def new_work_item(task, trigger) | |||
| def new_work_item(task, userinfo, trigger) | |||
There was a problem hiding this comment.
where is this called from? just line 172? https://github.com/chef/win32-taskscheduler/pull/31/files#diff-6e8eaa39e1a37c92c78a5801c8d9a3abL172
Don't we need to update everywhere this is called from as well to pass the same arguments?
There was a problem hiding this comment.
@btm thank you. I have fixed the code to give backward compatibility. There is call for new_work_item from https://github.com/chef/win32-taskscheduler/blob/ole/lib/win32/taskscheduler.rb#L172 which now does not require to do any changes since user information is now optional argument. I have related changes in the window_task PR here chef/chef#7288 which needs to be merged after this gets merged.
Signed-off-by: vasu1105 <vasundhara.jagdale@msystechnologies.com>
btm
approved these changes
Jun 4, 2018
Vasu1105
deleted the
vasundhara/fix_to_set_user_information_at_the_time_of_creation_of_task
branch
This was referenced Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should set user information at the time of creating task so if wrong username and password is provided the task should not get create.
StartWhenAvailable flag is false at the time of creation so set that also to false I have tested this flags value using scheduledtask.exe too.
Signed-off-by: vasu1105 vasundhara.jagdale@msystechnologies.com