Fix exists? method to find task in given path and if path or folder not present return false #40
Conversation
… folder not present return false Signed-off-by: vasu1105 <vasundhara.jagdale@msystechnologies.com>
lib/win32/taskscheduler.rb
Outdated
| @@ -193,7 +193,30 @@ def enum | |||
| # Returns whether or not the specified task exists. | |||
| # | |||
| def exists?(task) | |||
There was a problem hiding this comment.
I'd probably change task here to something like full_task_path so you aren't using task for two different things in this method (the fully qualified task path at first, and then an object returned by root.GetTask() later.)
lib/win32/taskscheduler.rb
Outdated
| task_name = nil | ||
|
|
||
| if task.include?("\\") | ||
| *path, task_name = task.split("\\") |
There was a problem hiding this comment.
Add a comment here like "# Use the splat operator put all folder elements into path and leave only the task name`
lib/win32/taskscheduler.rb
Outdated
| return false | ||
| end | ||
|
|
||
| task = nil |
There was a problem hiding this comment.
if you can avoid using task for two different purposes in this method you can drop this nil.
lib/win32/taskscheduler.rb
Outdated
| rescue WIN32OLERuntimeError => err | ||
| return false | ||
| end | ||
| end |
There was a problem hiding this comment.
what gets returned by this method here if root is nil? We seem to be returning true from line 215, task && task.Name == task_name but if for some reason root is false this block isn't run and we don't explicitly return anything. If we add an explicit return false to the end, we need to also add a return true after line 215.
Signed-off-by: vasu1105 <vasundhara.jagdale@msystechnologies.com>
…ot present return false (chef#40) * MSYS-834 Fix exists? method to find task in given path and if path or folder not present return false Signed-off-by: vasu1105 <vasundhara.jagdale@msystechnologies.com>
Signed-off-by: vasu1105 vasundhara.jagdale@msystechnologies.com