-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Session State Change #88
Conversation
Would be nice if we had a github action to run the spec tests and include them in PR's. Let me know if ya'll are interested in that and I can submit another PR. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks reasonable, though I admit I don't fully grok this codebase.
But merging without tests seems scary, so yes, if yo'ud be willing to make a PR to add GH test for the specs that'd be great. Thanks!
Looks like |
My instinct prefers the GitHub Actions route, but I'm willing to be convinced otherwise if that route has roadblocks with this code base. |
I also prefer Actions. You can see |
Kudos, SonarCloud Quality Gate passed! |
Screwed up my branches (commited this main). #90 is the new PR. My bad! |
Description
This adds support for Session State Change. This would allow tasks that happen on Lock/Unlock, RDP connection/disconnect, and Console Login/Logoff.
Issues Resolved
#87
Check List