Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Session State Change #88

Closed
wants to merge 0 commits into from

Conversation

HeyItsGilbert
Copy link
Contributor

@HeyItsGilbert HeyItsGilbert commented Mar 16, 2023

Description

This adds support for Session State Change. This would allow tasks that happen on Lock/Unlock, RDP connection/disconnect, and Console Login/Logoff.

Issues Resolved

#87

Check List

@HeyItsGilbert HeyItsGilbert requested review from a team as code owners March 16, 2023 20:51
@HeyItsGilbert
Copy link
Contributor Author

Would be nice if we had a github action to run the spec tests and include them in PR's. Let me know if ya'll are interested in that and I can submit another PR.

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tpowell-progress tpowell-progress self-assigned this Apr 25, 2023
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks reasonable, though I admit I don't fully grok this codebase.

But merging without tests seems scary, so yes, if yo'ud be willing to make a PR to add GH test for the specs that'd be great. Thanks!

@HeyItsGilbert
Copy link
Contributor Author

Looks like chef/mixlib-shellout relies on buildkite for that info. Not sure if folks want to plug into that or if a GH action would be preferred. Do we want to include that in this PR or should I do another?

@tpowell-progress
Copy link
Contributor

Looks like chef/mixlib-shellout relies on buildkite for that info. Not sure if folks want to plug into that or if a GH action would be preferred. Do we want to include that in this PR or should I do another?

My instinct prefers the GitHub Actions route, but I'm willing to be convinced otherwise if that route has roadblocks with this code base.

@jaymzh
Copy link
Collaborator

jaymzh commented May 2, 2023

I also prefer Actions. You can see chef/chef for an example. However, some stuff may only be available in buildkite, feel free to copy-paste that stuff if necessary. Definitely a separate PR, please.

@sonarcloud
Copy link

sonarcloud bot commented Jun 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@HeyItsGilbert
Copy link
Contributor Author

Screwed up my branches (commited this main). #90 is the new PR. My bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants