Add support for evaluating lazy attributes in templates #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
changed the title
stanhu
force-pushed
the
sh-support-lazy-attributes-in-template
branch
from
b4da4d2
to
dd95cd6
Compare
Previously if you had a template with `variables` that used the `lazy` keyword, previously it was not possible to validate that the blocks were evaluated in the template. The rendered string would contain an `<Chef::DelayedEvaluator>` string. This commit renders the variables to ensure the template renderer displays the lazily-evaluated values.
stanhu
force-pushed
the
sh-support-lazy-attributes-in-template
branch
from
dd95cd6
to
ae77ba2
Compare
|
@stanhu if you are still interested in getting this merged, please resubmit to chef/chefspec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you had a template with
variablesthat used thelazykeyword, previously it was not possible to validate that the blocks were evaluated in the template. The rendered string would contain an<Chef::DelayedEvaluator>string.This commit renders the variables to ensure the template renderer displays the lazily-evaluated values.