Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] PLEASE USE chef/chefspec for new pull requests #1030

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

tpowell-progress
Copy link

No description provided.

sachin007jain and others added 19 commits June 14, 2022 15:27
Signed-off-by: sachin007jain <sachin.jain@chef.io>
Signed-off-by: sachin007jain <sachin.jain@chef.io>
Obvious fix; these changes are the result of automation not creative thinking.
Obvious fix; these changes are the result of automation not creative thinking.
Obvious fix; these changes are the result of automation not creative thinking.
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
Obvious fix; these changes are the result of automation not creative thinking.
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
Obvious fix; these changes are the result of automation not creative thinking.
Obvious fix; these changes are the result of automation not creative thinking.
In this change, we are introducing a temporary version pin
of the rspec-expectations gem to version v3.12.3

As part of the v3.12.4/v3.13.0 releases, the private API class
RSpec::Matchers::ExpectedsForMultipleDiffs was renamed to
RSpec::Matchers::MultiMatcherDiff [1]. chefspec does make use of this
class in one instance.

A future change should be introduced to properly address this
class dependency. Possible options include replicating a minimal
replacement, or porting the class to equivalent custom matcher
with the chefspec codebase.

[1]: rspec/rspec-expectations@d0bb212

Signed-off-by: Joshua Riojas <joshuariojas.psu@gmail.com>
Signed-off-by: Joshua Riojas <joshuariojas.psu@gmail.com>
- Merge branch 'main' of github.com:joshuariojas/chefspec
- Add new commit so DOC Signoff check passes

Signed-off-by: Joshua Riojas <joshuariojas.psu@gmail.com>
Pin rspec-expectations due to private API change
Obvious fix; these changes are the result of automation not creative thinking.
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants