Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secondary download from github for json #7

Closed
sethvargo opened this issue Sep 3, 2012 · 0 comments
Closed

Secondary download from github for json #7

sethvargo opened this issue Sep 3, 2012 · 0 comments
Labels
Feature

Comments

@sethvargo
Copy link
Contributor

It doesn't make sense to release a new version of fauxhai every time we add a new platform.json file. Instead, we should look for the JSON locally, then search the official repo on github, then throw an error.
tmatilai pushed a commit to tmatilai/fauxhai that referenced this issue May 7, 2013
Remove dead code in #platform_path
f60c0d0 
The exception was never raised as there was a `File.exists?` missing.
But after chefspec#7 we anyway want to look for the Github repo before throwing
the exception. But improve the error message to include the platform.
@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sethvargo