Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIBytesPrefix setting to use SI prefix names in v3 #162

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Add SIBytesPrefix setting to use SI prefix names in v3 #162

merged 2 commits into from
Jan 9, 2020

Conversation

gnojus
Copy link
Contributor

@gnojus gnojus commented Dec 27, 2019

This was added in #111 on v1.
So I added it on v3.
Not sure about naming too.

@gnojus
Copy link
Contributor Author

gnojus commented Dec 27, 2019

Also fixed a test that was failing. Because of ⟝ character, which is 1.5 column length, but still displayed in one column in terminal. (go-runewidth returns length 1).

@cheggaaa cheggaaa merged commit fff55a4 into cheggaaa:master Jan 9, 2020
@cheggaaa
Copy link
Owner

cheggaaa commented Jan 9, 2020

Thank you!
go-runewidth was updated to v0.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnojus @cheggaaa