Some fixes for recent changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I haven't been able to give feedback lately; I was traveling.
Here are some fixes for your current work. A lot of it is cosmetic or merely simplifying the existing logic, but the most important thing was uncoupling the bridge implementations from the Core. We don't want our code littered with assumptions about the availability of a loaded project when all we need is two languages. It's better to put that dependency in one spot (where
LanguageToolWrapperinits the bridges) and pass the languages along as arguments.I haven't actually tested the dialog yet, but I'll try to get to it soon.