Fix for #10: May is missing from compact months #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I like your idea to use dot for short strings. I'm going to migrate this project to better-dom 2 soon... well, it depends on availability. Do you think it makes sense to add i18n section to the readme? I'm thinking of creating a global note and to reference it from projects. |
|
Hmm... If you have a global note, I think you don't need a section for it in each readme, just a link to this note |
|
Anyway, will do it later |
chemerisuk
added a commit
that referenced
this pull request
Oct 20, 2014
Fix for #10: May is missing from compact months
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a trailing dot for the compact months' keys, so that we can now have different keys for "May" (the full month) and "May." (the compact month).