New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read correct frame indices from TNG #430
Conversation
The changes looks good. I don't know why emscripten is failing on CI, I'll look into it. |
058d466
to
d0cead9
Compare
So I managed to update emscripten (sorry for the force push noise …) but it is now failing on MinGW. Seems that the root cause is that |
And update flags since the compiler now complains if it gets linker flags
d0cead9
to
fd12330
Compare
Thanks for your immediate action. I'll revert !27 here and if it works I'll add these changes to chemfiles/tng#1. Edit: MinGW seems to work now, but codecov is down :-(
Edit 2: Turns out I had a lot of luck and hit a 15 min time slot perfectly during which codecov had scheduled brownouts for soon-to-be deprecated services. However, simply copy and pasting the new uploader does not work. |
28e939f
to
fd12330
Compare
Ok, let's merge this and we'll see later how we can have similar code upstreamed! |
Depends on chemfiles/tng#1.
Updates the external TNG library to read the correct number of frames in a trajectory. Additionally, store the time of a frame as property, if present.
Fixes #425.