This repository has been archived by the owner on Nov 26, 2019. It is now read-only.
avoid expensive application_name call #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out calling Sufia helper is quite expensive, too expensive to do twice per member on a page that could have hundreds of members. Sufia::SufiaHelperBehavior#application_name We could have tried to figure out why it was expensive and optimized it, but we don't need it enough to be worth the time at present.
jrochkind
added a commit
that referenced
this pull request
Oct 10, 2017
Thought we did this earlier, but it got lost in a merge i guess. #720
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out calling Sufia helper application_name is quite expensive, too
expensive to do twice per member on a page that could have hundreds of members.
Sufia::SufiaHelperBehavior#application_name
We could have tried to figure out why it was expensive and optimized it, but
we don't need it enough to be worth the time at present.
PR'd to riiif branch, because this .erb code changed it's location
between master and riiif, didn't want to deal with the merge.