New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid expensive application_name call #720

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
2 participants
@jrochkind
Contributor

jrochkind commented Jul 19, 2017

It turns out calling Sufia helper application_name is quite expensive, too
expensive to do twice per member on a page that could have hundreds of members.
Sufia::SufiaHelperBehavior#application_name

We could have tried to figure out why it was expensive and optimized it, but
we don't need it enough to be worth the time at present.

PR'd to riiif branch, because this .erb code changed it's location
between master and riiif, didn't want to deal with the merge.

avoid expensive application_name call
It turns out calling Sufia helper  is quite expensive, too
expensive to do twice per member on a page that could have hundreds of members.
Sufia::SufiaHelperBehavior#application_name

We could have tried to figure out why it was expensive and optimized it, but
we don't need it enough to be worth the time at present.

@hackmastera hackmastera merged commit 4b7807b into riiif Jul 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hackmastera hackmastera deleted the avoid_expensive_application_name branch Jul 20, 2017

jrochkind added a commit that referenced this pull request Oct 10, 2017

remove reference to application_name for performance
Thought we did this earlier, but it got lost in a merge i guess.
#720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment